ngx-charts
ngx-charts copied to clipboard
fix(common): use valueFormatting if given to CountUpDirective
What kind of change does this PR introduce? (check one with "x")
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Other... Please describe:
What is the current behavior? (You can also link to an open issue here) [valueFormatting] is not used in CountUpDirective ([ngx-charts-count-up]) if argument is given after [countTo]. Issues such as https://github.com/swimlane/ngx-charts/issues/1514 reported.
What is the new behavior? [valueFormatting] is used.
Does this PR introduce a breaking change? (check one with "x")
- [ ] Yes
- [x] No
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Please can you make valueFormatting
take html entries and render html entities instead of just text?
Please can you make
valueFormatting
take html entries and render htlm entities instead of just text?
If that becomes a feature it will use templates and not HTML strings.
@Hypercubed Thanks for the quick response. That's fine too. I'm trying to render an svg with a tooltip plus make the units
value bold and also add some small text at the center of ngx-charts-gauge
since valueFormatting
isn't available in pie-grid
but I see it can only accept strings and auto sizes them.
before the feature comes up, any work around on this?
@Hypercubed Thanks for the quick response. That's fine too. I'm trying to render an svg with a tooltip plus make the
units
value bold and also add some small text at the center ofngx-charts-gauge
sincevalueFormatting
isn't available inpie-grid
but I see it can only accept strings and auto sizes them.before the feature comes up, any work around on this?
No work in progress that I know of. But as you can see we are very far behind on reviewing PRs. Sorry.