ngx-charts icon indicating copy to clipboard operation
ngx-charts copied to clipboard

[Feature] Add Series Tooltip Disabled Input to Line Chart

Open KingDarBoja opened this issue 5 years ago • 10 comments

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) Fixes #1132

What is the new behavior? Can set seriesTooltipDisabled input to only hide series tooltips on Line Chart.

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

KingDarBoja avatar May 26 '19 04:05 KingDarBoja

Nice! Can we add this to area charts too?

marjan-georgiev avatar Jul 22 '19 11:07 marjan-georgiev

Sure, I will add the feature as soon as I get some free time. :D

KingDarBoja avatar Jul 24 '19 23:07 KingDarBoja

@marjan-georgiev You are up to review, I can't assign it to anyone by the way lol

KingDarBoja avatar Jul 26 '19 01:07 KingDarBoja

Why is this PR still open?

codeepic avatar Oct 31 '19 16:10 codeepic

Why is this PR still open?

What do you mean? It is still open because it has to be reviewed again before merging to avoid any issue from the changes I made. 🍰

KingDarBoja avatar Nov 01 '19 23:11 KingDarBoja

Any chance to have this merged soon?

qortex avatar Dec 02 '19 14:12 qortex

Any chance to have this merged soon?

@marjan-georgiev Is there any chance that this one get reviewed in the short term?

KingDarBoja avatar Dec 17 '19 16:12 KingDarBoja

Hi, can someone tell me how can I disable the seriesTooltipTemplate ?

inarucast avatar Apr 02 '20 02:04 inarucast

Hi, can someone tell me how can I disable the seriesTooltipTemplate ?

Not possible at the moment unless this PR gets merged, in that case, you could set on the ngx-chart component template the [seriesTooltipDisabled]="false" .

KingDarBoja avatar Apr 02 '20 03:04 KingDarBoja

When does this PR will get merge?

AvielCo avatar Mar 07 '22 08:03 AvielCo