swift icon indicating copy to clipboard operation
swift copied to clipboard

[6.3] [Index] Relate ObjC optional protocol methods to protocol requirement

Open ileitch opened this issue 2 months ago • 3 comments

  • Explanation: When a class implements an optional ObjC protocol method, the indexer was not creating a RelationOverrideOf relation to the protocol requirement. Use findWitnessedObjCRequirements to find and index these optional requirements.
  • Scope: Purely additive to the index store. Can help tools such as Periphery be more accurate.
  • Issues: #56327
  • Original PRs: #86167
  • Risk: Very low, perhaps a slight increase in index store size.
  • Testing: Passed all tests across all platforms.
  • Reviewers: @hamishknight

ileitch avatar Jan 10 '26 18:01 ileitch

@swift-ci please test

hamishknight avatar Jan 10 '26 18:01 hamishknight

@hamishknight Is this good to merge now?

ileitch avatar Jan 16 '26 08:01 ileitch

Still needs branch manager approval, need to check whether it meets the bar for 6.3 changes at that this point into the release branch

hamishknight avatar Jan 16 '26 10:01 hamishknight

@swift-ci please test

hamishknight avatar Jan 21 '26 20:01 hamishknight