swift icon indicating copy to clipboard operation
swift copied to clipboard

[Sema] Try limit kicking interface type in `filterForEnumElement`

Open hamishknight opened this issue 11 months ago • 2 comments

Kicking the interface type request of the base decl here is wrong if the decl is e.g a self capture in a closure, since we'll be in the middle of type-checking the closure. I'm planning on properly fixing this by folding the lookup into the constraint system, but for now let's at least avoid kicking the request if we don't have an enum case or enum var. That at least prevents it from affecting cases where e.g you're pattern matching against a property in a class.

We could potentially tighten up the checking here even further, but that could potentially impact source compatibility for ambiguous cases. I'd like to keep this patch low risk, and then deal with any fallout as part of the pattern type-checking work.

rdar://146952007

hamishknight avatar Apr 09 '25 13:04 hamishknight

@swift-ci please test

hamishknight avatar Apr 09 '25 13:04 hamishknight

@swift-ci please test source compatibility

hamishknight avatar Apr 09 '25 13:04 hamishknight