Concurrency: remove workaround for silencing UB
The newer clang properly identifies UB on invalid pointer casts. This was previously being silenced by suppressing the warnings. Adjust the code to use std::bit_cast (or the shim implementation) to avoid the UB in this code.
@swift-ci please smoke test
@swift-ci please smoke test Linux platform
@swift-ci please smoke test Linux platform
@swift-ci please smoke test macOS platform
@swift-ci please smoke test Linux platform
@swift-ci please smoke test macOS platform
@swift-ci please smoke test macOS platform
@swift-ci please smoke test macOS platform
macOS failures:
Failed Tests (3):
Swift(macosx-x86_64) :: embedded/dependencies-concurrency-custom-executor.swift
Swift(macosx-x86_64) :: embedded/dependencies-concurrency.swift
Swift(macosx-x86_64) :: embedded/dependencies-concurrency2.swift
are because we gained a "memcpy" dependency:
******************** TEST 'Swift(macosx-x86_64) :: embedded/dependencies-concurrency-custom-executor.swift' FAILED ********************
Exit Code: 1
Command Output (stdout):
--
___assert_rtn
___stack_chk_fail
___stack_chk_guard
_abort
_clock_gettime
_exit
_free
_malloc
_memcpy
_memmove
_memset_s
_posix_memalign
_putchar
_puts
_strlen
_strncpy
_vprintf
_vsnprintf
...
+ test -z _memcpy
Adding "memcpy" to the allowlist of deps should resolve it.
Is there a reason that these tests are macOS only?
@swift-ci please smoke test
@swift-ci please test Windows platform