swift icon indicating copy to clipboard operation
swift copied to clipboard

utils: extract `Build-SDK` helper

Open compnerd opened this issue 9 months ago • 7 comments

This creates a helper for building the SDK for a given OS/Architecture. The building of the SDK should be uniform and this ensures that we can maintain that uniformity.

This also highlights any structural changes that are being adjusted manually. The desire is to bring this to zero by gaining control over the install rules.

compnerd avatar Mar 20 '25 05:03 compnerd

@swift-ci please smoke test

compnerd avatar Mar 20 '25 05:03 compnerd

@swift-ci please test Windows platform

compnerd avatar Mar 20 '25 15:03 compnerd

CC: @jeffdav

compnerd avatar Mar 20 '25 18:03 compnerd

I was excited until I read build.ps1.. nothing for me on Ubuntu

xavgru12 avatar Mar 20 '25 20:03 xavgru12

I was excited until I read build.ps1.. nothing for me on Ubuntu

Shouldn't be too terrible to port build.ps1 to run on Ubuntu. It will require just going through and adjusting the host expectation of Windows.

compnerd avatar Mar 20 '25 21:03 compnerd

@swift-ci please test Windows platform

compnerd avatar Mar 24 '25 20:03 compnerd

@swift-ci please smoke test

compnerd avatar Mar 26 '25 02:03 compnerd

@swift-ci please test Windows platform

compnerd avatar Mar 28 '25 20:03 compnerd

Why are you maintaining a windows only file? I figured this script‘s features would be more or less the same as build-script.

xavgru12 avatar Mar 28 '25 21:03 xavgru12

Why are you maintaining a windows only file? I figured this script‘s features would be more or less the same as build-script.

build-script is not portable; it does not support the necessary setup that Windows requires (integration with VS), support for cross-compilation, doesn't do the optimized build tricks that we do for minimizing the build, nor does it handle paths properly (path limits are a serious concern on Windows).

compnerd avatar Mar 29 '25 03:03 compnerd

@swift-ci please test Windows platform

compnerd avatar Mar 29 '25 03:03 compnerd

Please test with following PRs: https://github.com/swiftlang/swift-installer-scripts/pull/407

@swift-ci please test Windows platform

compnerd avatar Mar 29 '25 18:03 compnerd

@swift-ci please smoke test Linux platform

compnerd avatar Mar 30 '25 00:03 compnerd

@swift-ci please smoke test macOS platform

compnerd avatar Mar 30 '25 00:03 compnerd

@swift-ci please smoke test macOS platform

compnerd avatar Apr 01 '25 14:04 compnerd

According to https://github.com/swiftlang/swift/issues/80356#issuecomment-2762465479, this might fix #80356. Is there an ETA on when this will land?

bkhouri avatar Apr 04 '25 19:04 bkhouri

@bkhouri this needs @shahmishal or @etcwilde to approve https://github.com/swiftlang/swift-installer-scripts/pull/407, but this is ready to go otherwise.

compnerd avatar Apr 07 '25 15:04 compnerd