swift icon indicating copy to clipboard operation
swift copied to clipboard

Propagate vfs overlays and -fbuiltin-headers-in-system-modules

Open hjyamauchi opened this issue 9 months ago • 18 comments

This fixes explicit module builds for a hello world program on Windows as well as the ucrt import build failure as in the included test.

hjyamauchi avatar Mar 11 '25 22:03 hjyamauchi

This is a new fix to what https://github.com/swiftlang/swift/pull/78184 intended to fix and the win-crt.swift test comes from there.

hjyamauchi avatar Mar 11 '25 22:03 hjyamauchi

@swift-ci please test Windows platform

hjyamauchi avatar Mar 11 '25 22:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 11 '25 22:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 11 '25 22:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 12 '25 17:03 hjyamauchi

@swift-ci please test Linux platform

hjyamauchi avatar Mar 12 '25 21:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 14 '25 22:03 hjyamauchi

@ian-twilightcoder @cachemeifyoucan Please take another look

hjyamauchi avatar Mar 14 '25 22:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 15 '25 00:03 hjyamauchi

Does this fix https://github.com/swiftlang/swift/issues/70330 ? Can we re-enable no-implicit-extra-clang-opts.swift?

ian-twilightcoder avatar Mar 18 '25 21:03 ian-twilightcoder

Does this fix #70330 ? Can we re-enable no-implicit-extra-clang-opts.swift?

Doesn't seem to. Here's the output no-implicit-extra-clang-opts.swift.txt

hjyamauchi avatar Mar 19 '25 00:03 hjyamauchi

Does this fix #70330 ? Can we re-enable no-implicit-extra-clang-opts.swift?

Doesn't seem to. Here's the output no-implicit-extra-clang-opts.swift.txt

Well that's unfortunate

ian-twilightcoder avatar Mar 19 '25 00:03 ian-twilightcoder

@ian-twilightcoder Any more thoughts?

hjyamauchi avatar Mar 21 '25 16:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 21 '25 16:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 21 '25 23:03 hjyamauchi

Please take another look @cachemeifyoucan @ian-twilightcoder

hjyamauchi avatar Mar 25 '25 03:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 27 '25 20:03 hjyamauchi

Note: the CI passed at the current revision of this PR

hjyamauchi avatar Mar 28 '25 16:03 hjyamauchi

@swift-ci please test

hjyamauchi avatar Mar 28 '25 17:03 hjyamauchi

@swift-ci please test macos platform

hjyamauchi avatar Mar 28 '25 20:03 hjyamauchi