swift icon indicating copy to clipboard operation
swift copied to clipboard
verified publisher icon swiftlang

[6.1] Emit reabstraction thunks for implicit conversions between T.TangentType and Optional<T>.TangentType

Open clackary opened this issue 10 months ago • 3 comments

  • Explanation: Emit reabstraction thunks for implicit conversions between T.TangentType and Optional<T>.TangentType. Resolves a crash from silgen, producing a diagnostic instead.
  • Scope: Affects primarily autodiff code.
  • Issues: https://github.com/swiftlang/swift/issues/77871
  • Original PRs: https://github.com/swiftlang/swift/pull/78076
  • Risk: Low.
  • Testing: Verified the silgen crash still occurs on the latest release/6.1 snapshot, and the correct diagnostic is emitted using the latest main snapshot.
  • Reviewers: @asl @hamishknight @slavapestov

clackary avatar Feb 21 '25 17:02 clackary

cc @JaapWijnen

clackary avatar Feb 21 '25 17:02 clackary

@swift-ci Please test

slavapestov avatar Mar 07 '25 17:03 slavapestov

Ping @hamishknight @slavapestov...

Any concerns taking this for 6.1?

clackary avatar Mar 27 '25 16:03 clackary

Closing since we have an official 6.1 release.

clackary avatar Mar 31 '25 19:03 clackary