swift icon indicating copy to clipboard operation
swift copied to clipboard

Published 20 hours ago • verified publisher icon swiftlang

[c++ interop] Swift should allow multiple SWIFT_CONFORMS_TO_PROTOCOL attributes on a C++ class

Open CrazyFanFan opened this issue 9 months ago • 5 comments

Resolves https://github.com/swiftlang/swift/issues/75831

CrazyFanFan avatar Feb 17 '25 01:02 CrazyFanFan

@swift-ci please smoke test

j-hui avatar Feb 17 '25 04:02 j-hui

@j-hui Thank you for the review. CCC tests cases where a single class redundantly implements the same protocol. CCD was intended to test a correct combination, but since the combination issue was already tested in another file, the CCD here is indeed redundant. As for the multiple base classes, it was indeed overlooked, and I'll add it later.

CrazyFanFan avatar Feb 17 '25 05:02 CrazyFanFan

@swift-ci please smoke test

Xazax-hun avatar Feb 17 '25 11:02 Xazax-hun

@swift-ci please smoke test

j-hui avatar Mar 04 '25 06:03 j-hui

@swift-ci please smoke test

egorzhdan avatar Mar 28 '25 13:03 egorzhdan

@egorzhdan @j-hui can you assign this to me

ghost avatar Mar 30 '25 23:03 ghost

@swift-ci please smoke test Windows

egorzhdan avatar Apr 01 '25 14:04 egorzhdan

@swift-ci please smoke test

j-hui avatar Apr 03 '25 18:04 j-hui

@egorzhdan I have resolved the conflicts with the main branch. Could you please help to re-trigger the test job?

CrazyFanFan avatar Apr 06 '25 14:04 CrazyFanFan

@swift-ci please smoke test

Xazax-hun avatar Apr 06 '25 18:04 Xazax-hun

I noticed that my PR test failed, but it seems to be unrelated to the changes I made.

CrazyFanFan avatar Apr 07 '25 12:04 CrazyFanFan

@swift-ci please smoke test macos

Xazax-hun avatar Apr 07 '25 12:04 Xazax-hun