swift icon indicating copy to clipboard operation
swift copied to clipboard

[Interface] Always build swiftinterface when explicitly requested

Open cachemeifyoucan opened this issue 1 year ago • 3 comments

When explicitly requested to build a swiftinterface file to swiftmodule, alway perform the entire compilation, instead of immitating implicit build to do a up-to-date check in order to skip the compilation.

This can cause different build behavior depending on the order of the task, turning a failed compilation into a successful one. The next step might be using a stricter module hash to avoid output path collision all together.

rdar://131780720

cachemeifyoucan avatar Jul 15 '24 21:07 cachemeifyoucan

@swift-ci please smoke test

cachemeifyoucan avatar Jul 15 '24 21:07 cachemeifyoucan

@swift-ci please smoke test

cachemeifyoucan avatar Jul 15 '24 22:07 cachemeifyoucan

@swift-ci please smoke test

cachemeifyoucan avatar Jul 30 '24 16:07 cachemeifyoucan

@swift-ci please smoke test

cachemeifyoucan avatar Oct 01 '24 16:10 cachemeifyoucan

Landing this on rebranch instead.

cachemeifyoucan avatar Oct 01 '24 16:10 cachemeifyoucan

Landing this on rebranch instead.

I assume this depends on LLVM changes that we're not cherry-picking?

bnbarham avatar Oct 01 '24 16:10 bnbarham

I assume this depends on LLVM changes that we're not cherry-picking?

I don't think so. I don't know why I decide to rebase it on rebranch and pushed. Since it is not urgent, rebranch is fine (if I rebase it back, it is going to add 100 reviewers again).

cachemeifyoucan avatar Oct 01 '24 16:10 cachemeifyoucan

I don't think so. I don't know why I decide to rebase it on rebranch and pushed. Since it is not urgent, rebranch is fine (if I rebase it back, it is going to add 100 reviewers again).

In general if there's anything that can be on main it would be good to add it there instead. This isn't a large change though and I'm not super concerned about the conflicts caused from it, so it's fine.

bnbarham avatar Oct 01 '24 20:10 bnbarham

@swift-ci please smoke test

cachemeifyoucan avatar Oct 02 '24 23:10 cachemeifyoucan