swift icon indicating copy to clipboard operation
swift copied to clipboard

Windows: swift-docc fails during update-checkout because Package.resolved is deleted

Open eeckstein opened this issue 1 year ago • 4 comments
trafficstars

Description

It looks like that somewhere in the build process the Package.resolved file in swift-docc is deleted. This leads to a fail in update-checkout in subsequent builds:

======UPDATE FAILURES======
C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift-docc failed (ret=1): ['git', 'rebase', 'FETCH_HEAD']
b'error: cannot rebase: You have unstaged changes.\nerror: Please commit or stash them.\n'

Reproduction

See https://ci-external.swift.org/job/apple-llvm-project-pull-request-windows/96/console

Expected behavior

Package.resolved is not deleted

Environment

Reproducible with top of main. I could also reproduce it locally on my machine

Additional information

No response

eeckstein avatar May 03 '24 09:05 eeckstein

@compnerd do you have an idea what could delete the Package.resolved in the Windows build?

eeckstein avatar May 03 '24 09:05 eeckstein

@eeckstein nothing in the Windows build should be deleting that unless there is an explicit delete request. I would say just check build.ps1 to ensure that an errant Remove-Item didn't get committed. This is likely just a bug in SPM.

compnerd avatar May 03 '24 15:05 compnerd

Are you certain that the file has been removed? I suspect that this may just be differences in the platforms - NIO is not portable and have been unable to get the changes to enable portability merged, so we do not build parts of DocC.

compnerd avatar May 03 '24 15:05 compnerd

Are you certain that the file has been removed?

Yes, that's what I see locally on my machine, too

eeckstein avatar May 03 '24 18:05 eeckstein