swift
swift copied to clipboard
swiftlang
[Diagnostics-Qol]: Update c_style_for_stmt_removed error string
Changes Made
- Update the
c-style-for-stmt-removederror string - Updated appropriate tests in the
/testdirectory.
Resolves #73246
Just had some clarifications when running tests
- When do you need to rebuild dependencies when running tests?
- This was just updating an error string so does that warrant a rebuild?
- What steps should be taken with changes like this (what tests to run)?
When do you need to rebuild dependencies when running tests?
To put is simply, usually, the products you build to compile, debug and verify your changes are the exact same and only products you want to build before running associated tests. If build times are not a problem, run-test will build test dependencies for you. Otherwise, you learn them along the way. I prefer using lit or skipping the build phase in run-test (--build skip) because run-test is poorly optimized for small subsets of tests — it wastes time rebuilding unrelated stuff.
What steps should be taken with changes like this (what tests to run)?
What I do is search for occurrences of the old diagnostic message in the test suite, update them, and make sure those tests pass.
I suggest waiting for an approval from a code owner before rerunning the macOS smoke test. This is just a diagnostic reword and we know from the other successful smoke tests that all the right updates were made, so if the code owners happen to request amendments, we will have run the test for nothing.
