swiftlang
[SR-11588]Warn about derived Hashable implementation if there’s a custom Equatable
This is a first approach to add the desired warning for custom Equatable implementation during Hashable synthesis.
It’s working for struct just fine but it crashes when running test/Sema/implementation-only-import-in-decls.swift for some reason it don’t like enum types.
Other improvements before merging are increase the test coverage in test/Sema/diag_custom_equatable_syntheszied_hashable.swift and replicate the same warning in the opposite direction for custom Hashable implementation during Equatable synthesis.
Resolves SR-11588.
Please run clang-format as well to ensure your changes fit within the 80-column limit!
It’s working for struct just fine but it crashes when running test/Sema/implementation-only-import-in-decls.swift for some reason it don’t like enum types.
Can you share the stack trace?
Please run
clang-formatas well to ensure your changes fit within the 80-column limit!
I’ve run it on the file but it has changed a lot of formatting in the file apart the block I’ve added. It’s okay to add all the changes or is better to revert all the other changes and keep only my formatted block?
Can you share the stack trace?
Here it is.
1. Swift version 5.1.1-dev (LLVM f4c2b4eca6, Swift 32c1b05168)
2. While type-checking protocol conformance to 'Hashable' (in module 'Swift') for type 'TestRawType' (declared at [/swift-source/swift/test/Sema/implementation-only-import-in-decls.swift:65:8 - line:68:1] RangeText="enum TestRawType: IntLike { // expected-error {{cannot use struct 'IntLike' here; 'BADLibrary' has been imported as implementation-only}}
case x = 1
// FIXME: expected-error@-1 {{cannot use conformance of 'IntLike' to 'Equatable' here; 'BADLibrary' has been imported as implementation-only}}
")
0 swiftc 0x000000010d1be0c5 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
1 swiftc 0x000000010d1bd355 llvm::sys::RunSignalHandlers() + 85
2 swiftc 0x000000010d1be6b8 SignalHandler(int) + 264
3 libsystem_platform.dylib 0x00007fff57d2bb5d _sigtramp + 29
4 libsystem_platform.dylib 0x00007ffee841d608 _sigtramp + 2423200456
5 libsystem_c.dylib 0x00007fff57be56a6 abort + 127
6 libsystem_c.dylib 0x00007fff57bae20d basename_r + 0
7 swiftc 0x0000000109fb1b77 swift::RootProtocolConformance::getWitnessDeclRef(swift::ValueDecl*) const + 167
8 swiftc 0x0000000109fb03dd swift::ProtocolConformance::getWitnessDeclRef(swift::ValueDecl*) const + 93
9 swiftc 0x0000000109fb0366 swift::ProtocolConformanceRef::getWitnessByName(swift::Type, swift::DeclName) const + 198
10 swiftc 0x0000000109117245 swift::DerivedConformance::deriveHashable(swift::ValueDecl*) + 1093
11 swiftc 0x00000001093205bb swift::TypeChecker::deriveProtocolRequirement(swift::DeclContext*, swift::NominalTypeDecl*, swift::ValueDecl*) + 315
12 swiftc 0x0000000109320323 swift::ConformanceChecker::resolveWitnessViaDerivation(swift::ValueDecl*) + 275
13 swiftc 0x0000000109320f11 swift::ConformanceChecker::resolveWitnessTryingAllStrategies(swift::ValueDecl*) + 289
14 swiftc 0x00000001093221e1 swift::ConformanceChecker::resolveValueWitnesses() + 401
15 swiftc 0x000000010931a8a9 swift::ConformanceChecker::checkConformance(swift::MissingWitnessDiagnosisKind) + 553
16 swiftc 0x00000001093185dc swift::MultiConformanceChecker::checkIndividualConformance(swift::NormalProtocolConformance*, bool) + 3292
17 swiftc 0x0000000109317620 swift::MultiConformanceChecker::checkAllConformances() + 144
18 swiftc 0x00000001093242fb swift::TypeChecker::checkConformancesInContext(swift::DeclContext*, swift::IterableDeclContext*) + 1035
19 swiftc 0x0000000109479cc6 typeCheckFunctionsAndExternalDecls(swift::SourceFile&, swift::TypeChecker&) + 470
20 swiftc 0x000000010947a459 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int) + 1017
21 swiftc 0x0000000107e68735 swift::CompilerInstance::parseAndTypeCheckMainFileUpTo(swift::SourceFile::ASTStage_t, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) + 965
22 swiftc 0x0000000107e66bd0 swift::CompilerInstance::parseAndCheckTypesUpTo(swift::CompilerInstance::ImplicitImports const&, swift::SourceFile::ASTStage_t) + 384
23 swiftc 0x0000000107e66007 swift::CompilerInstance::performSemaUpTo(swift::SourceFile::ASTStage_t) + 807
24 swiftc 0x0000000107e6606a swift::CompilerInstance::performSema() + 26
25 swiftc 0x00000001078f3509 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) + 457
26 swiftc 0x00000001078f2589 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2121
27 swiftc 0x00000001077dfee4 run_driver(llvm::StringRef, llvm::ArrayRef<char const*>) + 292
28 swiftc 0x00000001077df1f3 main + 1875
29 libdyld.dylib 0x00007fff57b403d5 start + 1
30 libdyld.dylib 0x0000000000000013 start + 2823552063
@DougGregor sorry to ping, but I've read in the CODE_OWNERS file that you are associated with the Sema. Do you know how can I catch that the equality conformance is implemented in another module and that I cannot get the witness for it?
I‘ve tried to look everywhere but I’m not seeing anything useful for a check against it :(
Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.
@beccadax hi, sorry to ping you, I've finally solved the issue and on my mac all the tests are running fine. There is more changes I have to do?
I've rebased the repo and run all the tests with utils/run-test --lit ../llvm-project/llvm/utils/lit/lit.py ../build/Ninja-RelWithDebInfoAssert/swift-macosx-$(uname -m)/test-macosx-$(uname -m) and nothing is breaking this time.
