Sketchbook icon indicating copy to clipboard operation
Sketchbook copied to clipboard

Compatibility with latest version of THREE.js

Open ManuBernard opened this issue 3 years ago • 2 comments

Hi ! Amazing project ! It's super impressive !

I'am trying to use some of the development you have made in an other project and it highlited that THREE.JS has changed.

new THREE.Geometry() (used in three-to-cannon.js) is not supported anymore.

Do you plan to fix this ? If not could you point a direction about how to replace this ?

Thanks a lot :)

ManuBernard avatar Feb 21 '21 00:02 ManuBernard

Hi! Glad you like the project.

I'm not planning to upgrade three in the project in the near future. I tried upgrading right before releasing 0.4, but found that animation blending stopped working, and I have no idea how to fix that. And similarly I have no clue how to fix the bug you're describing.

Generally I've paused the development of Sketchbook for any forseeable future, as I have other projects to look after, so I'm afraid you're on your own here. Though I'll be happy to accept PRs should you manage to fix the problems.

swift502 avatar Feb 26 '21 11:02 swift502

I can recommend the three.js migration guide. https://github.com/mrdoob/three.js/wiki/Migration-Guide They document the migration changes for every release. Start from 113 and look for any THREE.Geometry notes.

The rate at which three.js breaks compatibility has been a contentious topic for a while. It makes it really difficult to stay up to date with the latest version for a project like Sketchbook.

swift502 avatar Feb 26 '21 12:02 swift502