swiftly icon indicating copy to clipboard operation
swiftly copied to clipboard
verified publisher icon swift-server

Run shellcheck on swiftly-install.sh

Open patrickfreed opened this issue 2 years ago • 6 comments

shellcheck is a static analysis tool for bash which can catch a number of common bash issues. We should run it on swiftly-install.sh and include it in the soundness check CI task.

patrickfreed avatar Sep 21 '23 07:09 patrickfreed

This should be part of the CI setup as well

adam-fowler avatar Sep 21 '23 09:09 adam-fowler

bash is a kind of deprecated on macOS. Better use posix shell for max compatibility.

Zingam avatar Dec 19 '23 11:12 Zingam

bash is a kind of deprecated on macOS. Better use posix shell for max compatibility.

Do you mean deprecated in that it isn't the default shell on macOS anymore or that Apple intend to delete it in a future release of macOS. If it is the second can you post where Apple announced this.

Currently bash is available on pretty much every Linux release. I'll have to let @patrickfreed cover any issues with falling back to posix shell.

adam-fowler avatar Dec 19 '23 12:12 adam-fowler

I think we should close this as the installer is now written in Swift.

cmcgee1024 avatar Sep 12 '24 19:09 cmcgee1024

I think we should close this as the installer is now written in Swift.

https://github.com/swiftlang/swiftly/blob/a7ef9e838b21b7f2836f318e67b4bffa6bee259f/install/swiftly-install.sh (the script this issue is talking about) is not written in swift

Gingeh avatar Sep 18 '24 05:09 Gingeh

@Gingeh the shell scripts has been replaced by the swiftly init subcommand. Before next release we will be removing the shell script entirely in favour of guidance on the swift.org download page that gets the user to that subcommand to complete the installation.

cmcgee1024 avatar Sep 18 '24 11:09 cmcgee1024