swiftly icon indicating copy to clipboard operation
swiftly copied to clipboard

Consistency in y/n prompts

Open carlynorama opened this issue 1 year ago • 2 comments

Some accept just y or just Y some both. (swifty-install.sh, the intro to the package accepts both.)

MacOS.swift and Linux.swift go their own ways in asking for confirmation (line 121, 135 respectively) in their use() functions for overwriting symlinks, only accepting y, but not warning on a Y.

perhaps these functions should be using

promptForConfirmation(defaultBehavior: Bool) from Utils.swift (line 19)?

carlynorama avatar Jul 21 '24 00:07 carlynorama

Yeah we should definitely be consistent with this. Merging swiftly-install.sh into swiftly itself will help with that too, we just need to make sure to use the same promptForConfirmation everywhere once we do that.

patrickfreed avatar Jul 26 '24 15:07 patrickfreed

@cmcgee1024 Can you verify your swiftly init PR is consistent

adam-fowler avatar Aug 02 '24 08:08 adam-fowler