swiftly icon indicating copy to clipboard operation
swiftly copied to clipboard

Align SwiftlyVersion with semver prereleases

Open cmcgee1024 opened this issue 1 year ago • 11 comments

Change SwiftlyVersion to make it more conformant to the semantic version specification (https://semver.org) with respect to pre releases. Add test cases that cover typical scenarios. Update the swiftly version to a "dev" pre-release.

cmcgee1024 avatar Jul 05 '24 17:07 cmcgee1024

@swift-server-bot test this please

cmcgee1024 avatar Jul 05 '24 17:07 cmcgee1024

I've seen a few I think. I've used @gwynne's SemVer library in Penny and it's been working fine.

MahdiBM avatar Jul 09 '24 07:07 MahdiBM

@swift-server-bot test this please

cmcgee1024 avatar Jul 09 '24 14:07 cmcgee1024

@swift-server-bot test this please

cmcgee1024 avatar Jul 09 '24 18:07 cmcgee1024

I've seen a few I think. I've used @gwynne's SemVer library in Penny and it's been working fine.

I'd vote for using this

adam-fowler avatar Jul 10 '24 09:07 adam-fowler

I try to be careful when adding more dependencies. It feels like swiftly should try to minimize them. Should we add a new dependency for something that we already have, doesn't involve much code, and is customized to suit the need here? What would be the benefits of adding such a dependency?

cmcgee1024 avatar Jul 11 '24 12:07 cmcgee1024

@cmcgee1024 It's generally a good idea to not depend on just any package, but it applies less here, because:

  • Swiftly is not a library, so having a new dependency won't make other people's dependency trees bigger.
  • Using the library is less code you need to maintain yourself.
  • @gwynne is a stablished member of the community so we can feel more relaxed when depending on her libraries.
  • Security wise, @gwynne would know enough to try to not introduce security problems (not that the package contains anything sensitive). She has contributed a bunch of stuff like RSA to SwiftCrypto as well.
  • @gwynne is a member of the SemVer org.

MahdiBM avatar Jul 11 '24 12:07 MahdiBM

@swift-ci test macOS

cmcgee1024 avatar Jul 12 '24 18:07 cmcgee1024

@swift-server-bot test this please

adam-fowler avatar Jul 21 '24 18:07 adam-fowler

@swift-ci test macOS

adam-fowler avatar Jul 21 '24 18:07 adam-fowler

@swift-ci test macOS

cmcgee1024 avatar Jul 24 '24 19:07 cmcgee1024

I'm closing this for now since there's no real urgency to aligning swiftly more with the sermver spec. We have already bumped the swiftly version to a 0.4.0 prerelease version.

cmcgee1024 avatar Aug 22 '24 12:08 cmcgee1024