swift-prometheus icon indicating copy to clipboard operation
swift-prometheus copied to clipboard

Published 20 hours ago • verified publisher icon swift-server

Fix behaviour for all metric types when only calls with labels are made

Open MrLotU opened this issue 2 years ago • 4 comments

Fixes #80 #77

Checklist

  • [x] The provided tests still run.
  • [x] I've created new tests where needed.
  • [x] I've updated the documentation if necessary.

Fixes an internal inconsistency where recording to a summary or histogram with labels would overflow into their main (no labels) versions too. (#77)

Also removes "empty" reports of metrics (#80)

MrLotU avatar Dec 07 '22 12:12 MrLotU

@MrLotU I understand that this PR has been open for a while, and it appears that some fixes were merged in the past. Nevertheless, I wanted to reach out and inquire if there’s anything else you believe we could improve upon. Additionally, there’s been a significant change in the code base recently. Thank you!

incertum avatar Sep 08 '25 22:09 incertum

Hey @incertum, I'm honestly not quite sure why this PR was not merged when it was opened 3 years ago. I'm no longer actively involved with the project, so happy for this to be merged if the original issues still need to be addressed, and this PR is still a fair solution with all the evolution this project has gone through since the opening of this PR.

Also more than happy to have it closed if the original issues have been solved in some different way, or if the implementation in this PR is no longer in line with the projects current setup.

MrLotU avatar Sep 09 '25 01:09 MrLotU

Hey @incertum, I'm honestly not quite sure why this PR was not merged when it was opened 3 years ago. I'm no longer actively involved with the project, so happy for this to be merged if the original issues still need to be addressed, and this PR is still a fair solution with all the evolution this project has gone through since the opening of this PR.

Also more than happy to have it closed if the original issues have been solved in some different way, or if the implementation in this PR is no longer in line with the projects current setup.

Please accept our apologies for not having reviewed this PR. I’ll check this thoroughly and reply next week.

incertum avatar Sep 09 '25 20:09 incertum

Nono, absolutely no worries. I'm 99% sure this PR was opened by me when I was still actively maintaining this project, and just had it somehow completely fall of my radar

MrLotU avatar Sep 09 '25 21:09 MrLotU