async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Published 20 hours ago • verified publisher icon swift-server

Make Task.logger accessible to delegate implementations outside of Package

Open felixschlegel opened this issue 3 years ago • 9 comments

Motivation:

This change was proposed in issue #389.

Users writing their own HttpClientResponseDelegate implementation might want to emit log messages to the task's logger.

Modifications:

Changed the access level of Task's logger property from internal to public.

Result:

Users can access the logger property of a Task outside of the async-http-client Package.

felixschlegel avatar May 24 '22 13:05 felixschlegel

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar May 24 '22 13:05 swift-server-bot

@swift-server-bot add to allowlist

glbrntt avatar Jul 20 '22 10:07 glbrntt

@swift-server-bot test this please

fabianfett avatar Jul 20 '22 10:07 fabianfett

@swift-server-bot test this please

dnadoba avatar Jan 22 '23 17:01 dnadoba

@felixschlegel thanks a lot for the patch! sorry for the delay.

dnadoba avatar Jan 22 '23 19:01 dnadoba

thanks a lot for the patch! sorry for the delay.

No problem 😄 Thanks for merging!

felixschlegel avatar Jan 22 '23 19:01 felixschlegel