pilotclient icon indicating copy to clipboard operation
pilotclient copied to clipboard

Fix ATIS messages silently dropped when containing placeholder lines

Open Copilot opened this issue 3 months ago • 3 comments

Fixes #359. VATSIM ATIS messages containing placeholder lines (e.g., "z", "z1", "z2") were silently dropped and never displayed to users.

Root Cause

In updateAtisMap(), three return statements inside a for loop exit the entire function when a placeholder line is encountered, preventing the atisReplyReceived signal from being emitted:

// Before: exits function, drops entire ATIS
if (test == "z") return;
if (test.startsWith("z") && test.length() == 2) return;
if (test.length() == 1) return;

Fix

Changed return to continue to skip placeholder lines while still processing remaining content:

// After: skips line, continues processing
if (test == "z") continue;
if (test.startsWith("z") && test.length() == 2) continue;
if (test.length() == 1) continue;
Original prompt

Investigate the reason for issue 359


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot avatar Nov 29 '25 16:11 Copilot