pilotclient icon indicating copy to clipboard operation
pilotclient copied to clipboard

Consider using CGenericDBusInterface::relayParentSignals

Open oktal3700 opened this issue 5 years ago • 0 comments

Regarding comment in blackmisc/genericdbusinterface.h:

//! \deprecated KB 2018-08 this seems to be not used anymore and might be removed
void relayParentSignals()
{
    Q_ASSERT_X(false, Q_FUNC_INFO, "crosscheck if still used");

We could use relayParentSignals to avoid a lot of difficult-to-maintain, difficult-to-test boilerplate code in the relaySignals method of all our DBus proxy classes.

The entirety of each relaySignals method of the contexts could be replaced with a call to m_dBusInterface->relayParentSignals(). And the same for the equivalent parts in the constructors of the xswiftbus proxy classes in the XP driver.

oktal3700 avatar Jun 07 '20 22:06 oktal3700