setup-swift icon indicating copy to clipboard operation
setup-swift copied to clipboard

Adds Swift v6.0

Open NeedleInAJayStack opened this issue 1 year ago • 8 comments

This adds swift 6.0.0 to the available version list.

I mainly just copied https://github.com/swift-actions/setup-swift/commit/7090b9ff07db2f5273e63de85f7ea7357c4335fd, please let me know if there's more I should do!

NeedleInAJayStack avatar Sep 21 '24 15:09 NeedleInAJayStack

Attempts to resolve https://github.com/swift-actions/setup-swift/issues/683

NeedleInAJayStack avatar Sep 21 '24 15:09 NeedleInAJayStack

Example of working downstream job: https://github.com/GraphQLSwift/GraphQL/actions/runs/10973971885/job/30471967466?pr=150

NeedleInAJayStack avatar Sep 21 '24 16:09 NeedleInAJayStack

@NeedleInAJayStack for projects which pin their workflows to patch level could you please add 6.0.0 as well?

Aaron-Ritter avatar Sep 25 '24 13:09 Aaron-Ritter

could you please add 6.0.0 as well?

Sure, I've added 6.0.0.

NeedleInAJayStack avatar Sep 25 '24 15:09 NeedleInAJayStack

I can confirm @NeedleInAJayStack's solution works: https://github.com/MortenGregersen/Bagbutik/actions/runs/11029802109

MortenGregersen avatar Sep 26 '24 08:09 MortenGregersen

@fwal Bumping here as Swift 6 has been out for several weeks now and is a blocker on CI jobs

bilaalrashid avatar Oct 10 '24 22:10 bilaalrashid

While we are waiting for this PR to be merged, our team solved CI issue by using the latest macOS version (15.0) that includes Xcode 16.0 and Swift by default.

You can use these commands and don't need to include @setup-swift action.

name: Build iOS app
   runs-on: macos-15
   steps:
     - name: Get swift version
       run: swift --version # Swift 6.0
     - name: Select Xcode
       run: sudo xcode-select -s '/Applications/Xcode_16.0.app/Contents/Developer'

ulian-onua avatar Oct 11 '24 09:10 ulian-onua

@fwal / @slashmo Any thoughts on this - I'd be happy to add 6.0.1 in this same pull request if you prefer.

NeedleInAJayStack avatar Oct 26 '24 19:10 NeedleInAJayStack

Looking at the ongoing conversation, would it make sense to not only allow the installation of the specified list of versions but allow any SEMVER format outside that list with a "default process" and with the risk of failing? And e.g. a output that you're using a untested version?

Aaron-Ritter avatar Nov 05 '24 17:11 Aaron-Ritter

Hello everyone! 👋🏻 Sorry for the late response, I'll get this out now.

fwal avatar Jan 14 '25 06:01 fwal