setup-swift icon indicating copy to clipboard operation
setup-swift copied to clipboard

Add Windows support

Open soumyamahunt opened this issue 2 years ago • 3 comments

This PR works on top of #140, to provide Windows runner support.

Tasks completed by @fwal in #140:

  • [x] Resolve correct version
  • [x] Download Swift package

Tasks completed in this PR:

  • [x] Setup Swift on windows
  • [x] GPG signature validation
  • [x] Tests

Fixes #132.

soumyamahunt avatar Jun 07 '22 07:06 soumyamahunt

@slashmo @fwal I have made changes for windows setup actions as mentioned in the docs, please review and let me know if any further changes needed.

soumyamahunt avatar Jun 07 '22 07:06 soumyamahunt

Hi @soumyamahunt! 👋🏻

Thanks for your contribution, this looks great! Could you remove any changes made in the dist folder? We let GitHub actions and manual builds manage that.

fwal avatar Jun 21 '22 08:06 fwal

Hi @soumyamahunt! 👋🏻

Thanks for your contribution, this looks great! Could you remove any changes made in the dist folder? We let GitHub actions and manual builds manage that.

Hi @fwal, the changes to the dist folder are auto-generated and shouldn't impact the action. I pushed these changes since I am using this branch in my swift-package jobs until swift-actions creates a new release with windows support. Removing these changes will break those jobs.

soumyamahunt avatar Jun 22 '22 04:06 soumyamahunt

@soumyamahunt This is due to security concerns, I would rather not have the dist folder checked in at all but that's just how actions work 😅 I'll sanitise in another branch and merge this in!

fwal avatar Sep 11 '22 12:09 fwal