secret-service icon indicating copy to clipboard operation
secret-service copied to clipboard

Published 20 hours ago • verified publisher icon swiesend

Update to `dbus-java` 4.x

Open overheadhunter opened this issue 3 years ago • 8 comments
trafficstars

This is a feature request that will not be downwards compatible and may require a new major version:

Could you please update dbus-java to version 4? It got modularized and offers a variety of transport implementations, including dbus-java-transport-native-unixsocket, which relies on Java's native unix sockets, so we could get rid of the dependency to the whole JNR ecosystem.

This requires to bump the JDK to 17 (technically 16, but I guess LTS makes more sense). On the long run, this is the most important step to make this library work with Java's module system.

overheadhunter avatar Jan 27 '22 09:01 overheadhunter

I have seen it. Last time I checked there was no jar on maven yet, as the 4.x version was just released. I try it for this week. Will also update the intergrations-linux.

swiesend avatar Feb 07 '22 17:02 swiesend

I found some time to integrate dbus-java 4.x.x. I am planning to release it together with my 2.x.x API, that will provide a FP friendly API, as you suggested in: https://github.com/swiesend/secret-service/issues/7

I want to release my 2.0.0, when dbus-java 4.1.x will be available.

https://github.com/swiesend/secret-service/tree/develop-2.x.x

swiesend avatar Apr 03 '22 15:04 swiesend

This may be a little off topic but since you mentioned working on a new major version (and probably don't want to have further breaking changes after releasing it): Please consider using a package namespace that you have sole control over, as org.gnome.* and org.freedesktop.* etc will lead to split packages in the post-Java-8 modular world.

Convention would be for Maven group/artifact, Java module name and root package name to match.

overheadhunter avatar Apr 04 '22 05:04 overheadhunter

I've also been waiting on dbus-java 4.1.x for other purposes, as well as being a consumer of this library (via https://github.com/javakeyring/java-keyring). So just thought I'd point out 4.1.0 has now been released :)

brett-smith avatar May 23 '22 23:05 brett-smith

So just thought I'd point out 4.1.0 has now been released :)

Thanks @brett-smith! Currently I am on vaccation without my laptop. I am happy to use it when I am back in about two weeks.

swiesend avatar May 25 '22 05:05 swiesend

Since the jnr-based unix sockets implementation might fail in downstream projects, may I ask for our users, if there is any progress with this?

overheadhunter avatar Sep 04 '22 22:09 overheadhunter

@overheadhunter there is some progress, but its not pushed as it is not finished. Recently my father died and there are too many things going on right now. I try to find some spare time to get if off the table, but that probably need some more weeks. But its not forgotten.

swiesend avatar Oct 07 '22 10:10 swiesend

So sorry to hear that! Trust me, I know how this can derail one's life from one day to the other.

Don't feel pushed, I was just curious what is the status of this issue.

overheadhunter avatar Oct 08 '22 08:10 overheadhunter

This issue is completed with the release of https://github.com/swiesend/secret-service/tree/v1.8.0-jdk17.

infeo avatar Jan 16 '23 16:01 infeo

There is https://github.com/swiesend/secret-service/releases/tag/v1.8.1-jdk17 with dbus-java-transport-native-unixsocket

swiesend avatar Jan 17 '23 09:01 swiesend