Results 409 comments of Sebastian Wick

Just a note, you can download the container image and `podman run` to reproduce the issue locally. Probably much easier than having to rely on the CI logs.

Looked at the tests now and I was able to reproduce the issue when running a bunch of those test cases in parallel. Really not sure what's going on there...

This version has my changes to the implementation in xdp and your changes to the tests, with the race fixed: https://github.com/swick/xdg-desktop-portal/tree/wip/document-path-resolve

The diff between my branch and this PR ```diff diff --git ./tests/meson.build ../tests/meson.build index 88e7729e..1cc6a5ed 100644 --- ./tests/meson.build +++ ../tests/meson.build @@ -149,6 +149,7 @@ if enable_installed_tests '__init__.py', 'conftest.py', 'xdp_utils.py', +...

Couldn't resist using parameterize to cut down the testing code: https://github.com/swick/xdg-desktop-portal/commit/eddb101c8ca99b897952fedcc41dd34ffbc708fe

Rebased and added the cleanup for the tests. From my POV this looks good to merge. @GeorgesStavracas @jadahl

(only rebased to make sure everything still works)

I'd really like if the test was moved over to python.

Regarding the appid mismatch that unfortunately still happens: I'd much rather see us adding https://github.com/flatpak/xdg-desktop-portal/pull/1521 than special casing every portal that firefox actually depends on.

The permission store is supposed to get started (https://github.com/flatpak/xdg-desktop-portal/blob/1c902cc77e53b422d49988bab58b6cca0ed9b112/tests/conftest.py#L458C5-L458C25) when the test case uses either the `xdg_permission_store` or the more general `portals` fixtures.