Sebastian Wick
Sebastian Wick
I've also found it not obvious sometimes that you're giving access to an entire folder to the app and if we want to let apps access neighboring files this issue...
This contains commits which are broken by themselves. Can you please squash thing properly so that each commit is working?
The changes look fine to me.
Hard to see what changed because of the indentation changes and rebase.
I've taken another look and didn't find anything that stood out. @mardy can you also please take another look?
LGTM but we should definitely get another review in.
A few nits but LGTM in general.
> Ok, looking at the tests, seems like I introduced some leak that I am unable to find :( Since the tests were formerly passing, either this is from using...
The CI doesn't fail because of a leak: ``` ++ assert_not_reached 'Timed out when looking for update 1' Timed out when looking for update 1 ```
And I get the same problem on main. Your code should be fine but we should figure out what's going on... e: this persists also a few hundred commits earlier...