ueberauth_microsoft icon indicating copy to clipboard operation
ueberauth_microsoft copied to clipboard

Implement logout

Open benkeil opened this issue 4 years ago • 3 comments

As far as I see, there is no logout implemented. Or did I missed something?

https://docs.microsoft.com/en-us/azure/active-directory/develop/scenario-web-app-sign-user-sign-in?tabs=aspnetcore#sign-out

benkeil avatar Aug 11 '21 07:08 benkeil

Hi, thanks for raising this.

My understanding is ueberauth only focuses on authenticating requests and doesn't look to implement anything in addition to that. This doesn't necessarily mean this library couldn't support additional authentication features, though to break consistency with other ueberauth adapters I feel it would need to be clear why it is necessary.

I have had a quick look at some of the official ueberauth adapters (google, facebook, github) and those don't appear to support logout. Are you aware of any other adapters that support this feature?

swelham avatar Aug 17 '21 10:08 swelham

I‘m not deep enough in the topic to be honest.

I also don’t know what a User really wants. min the other hand, I expect the effort is not very high and it is not bad to have this feature?

benkeil avatar Aug 17 '21 10:08 benkeil

Thanks for the feedback.

I think it would be great to look into this feature and I'm definitely open to a PR if anyone reading this is interested.

swelham avatar Aug 20 '21 14:08 swelham