cashier icon indicating copy to clipboard operation
cashier copied to clipboard

Braintree support

Open krapans opened this issue 8 years ago • 6 comments

Would love to see braintree support for this.

krapans avatar Feb 03 '17 11:02 krapans

:+1: Absolutely!

@aseigo is currently looking into stripe support, so this one should be next when I get time (unless someone takes it first).

swelham avatar Feb 03 '17 11:02 swelham

There is an actively developed Braintree lib for elixir here: sorentwo/braintree-elixir

Might be a useful starting point; perhaps @sorentwo would even be interested in collaborating/ coordinating...

aseigo avatar Feb 04 '17 09:02 aseigo

Hey, thanks for mentioning me. Integrating with Braintree is a bit more complex than integrating with Stripe, largely because it is all over XML. I'm available to answer any questions that come up as you work on things and coordinate, but I wouldn't want to re-implement my efforts on braintree-elixir.

sorentwo avatar Feb 06 '17 18:02 sorentwo

Hi, I think @aseigo was more suggesting that we use your braintree-elixir lib as a dependency for the implementation in cashier. I originally intended to steer clear of taking on gateway specific dependencies, however I aim to split out the gateways into their own hex packages at which point I don't feel that will cause much of an issue.

swelham avatar Feb 06 '17 19:02 swelham

@swelham Thanks for the clarification! Gateways sound like a good option to me. Keeping them in separate packages makes sense, though with mix/hex it is possible to declare optional dependencies and conditionally compile each gateway. If you're starting out with one or two gateways that may make testing and development simpler, with no negative impact on end users.

sorentwo avatar Feb 07 '17 15:02 sorentwo

Awesome! I didn't know about the optional dependencies option in mix, I will definitely look into that.

swelham avatar Feb 07 '17 16:02 swelham