python-novice-inflammation icon indicating copy to clipboard operation
python-novice-inflammation copied to clipboard

Overall review of lesson 2016-06 by @valentina-s

Open valentina-s opened this issue 8 years ago • 2 comments

  • [X] [01-numpy] Typo in Data Type section: We can also find the out the type of the data contained in the NumPy array.
  • [X] [01-numpy] Issue with sentence: 'More convenient when indices are computed rather than constant' - I don't understand the ending - seems unfinished.
  • [ ] [01-numpy] Multiple assignment - move it to later, maybe when discussing creating own functions maxval, minval, stdval = numpy.max(data), numpy.min(data), numpy.std(data)
  • [X] [01-numpy] Change 'What if we need the maximum inflammation for all patients' to 'inflammation for each patient over all days'
  • [X] [01-numpy] Typo in sentence: 'The mathematician Richard Hamming once said ... (or course) ...'
  • [X] [01-numpy] Exercise – Drawing Straight Lines (Why are we expecting the lines to be straight?)
  • [ ] [02-loops] Explicitly say that the collections is the word = collection of characters.
  • [X] [02-loops] Collection is not ordered - use sequence instead of collection.
  • [ ] [02-loops] Range does not produce a list in Python 3, so students cannot see the output of range.
  • [X] [03-lists] State 'individual values and characters' in 'There is one important difference between lists and strings: we can change the values in a list, but we cannot change the characters in a string.'
  • [X] [03-lists] Why not use Darwin instead of Bell?
  • [X] [03-lists] Substitute equally with similarly in 'And equally, you can omit the ending index in the range to take a slice to the very end of the sequence'?
  • [X] [03-lists] Some formatting issue before Tuples and Exchanges exercise
  • [X] [03-lists] Tuples and Exchanges - since tuples have been removed, title should be changed, also I do not think the goal of the exercise is very clear, maybe relate to multiple assignment
  • [X] [03-lists] Typo 'the the' in: If we want to start by analyzing just the first three files in alphabetical order, we can use the sorted built-in function to generate a new sorted list from the the glob.glob output.
  • [X] [05-cond] Repetition of Tuples and exchanges: move or remove
  • [X] [06-func] Type in: 'min, mean, and and max of centered data are'
  • [ ] [07-errors] Decide on what to do with the error python code.
  • [X] [08-defensive] In Pre- and Post-Conditions Exercise change 'hers' to 'his/hers' in 'Compare your answer to your neighbor's: can you think of a function that will pass your tests but not hers or vice versa?'
  • [ ] [10-cmdline] Explain how to use the readings.py files - download, create during the session?

More Major Organizational Remarks:

  • [X] [01-numpy] Start lessons with introducing simple variables? We now begin the lesson with loading the csv file into a numpy array (but we don't really use it), then introduce simple variables, then go back to working with the numpy array. I wonder if it would be better (especially for novices) to start with the simple variables first, and then continue with numpy.
  • [ ] [02-loops] What is the motivation for teaching loops before lists? I think the example of looping through the elements of a string confusing (and that is what I have heard form students) as a word is interpreted as a whole not as a collection of characters. I think the lesson order can be reversed.

valentina-s avatar Jul 15 '16 03:07 valentina-s

Thanks very much for this - I'll mark it as "help wanted", and pull requests from anyone and everyone would be very welcome.

gvwilson avatar Jul 15 '16 14:07 gvwilson

@valentina-s I am interested in fixing the issue in NumPy episode.

souravsingh avatar Sep 25 '17 17:09 souravsingh