python-novice-gapminder
python-novice-gapminder copied to clipboard
add linebreak in looping example
Add a newline in the print for the looping over files minimum example to improve readability of output.
Thank you!
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
- :dart: correct output
- :framed_picture: correct figures
- :question: new warnings
- :bangbang: new errors
Rendered Changes
:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-647
The following changes were observed in the rendered markdown documents:
14-looping-data-sets.md | 8 +++++---
md5sum.txt | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
What does this mean?
If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.
This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.
:stopwatch: Updated at 2023-05-19 19:25:02 +0000
I noted later: I think there are other exercises this update would apply to as well. I won't have time to check in the near future though. Probably either someone should scan through the code/output in this episode or create an issue to follow up.
Hi @ndporter, thank you for the PR. I note however that this requires explaining what \n
means. Do you remember if there's another place before this point where it is used in the lesson materials?
Alternatively, what do you think of doing two prints? As in
print(filename)
print(data.min())
The \n
construction is used as early as thepandas data frames
lesson (link from aio because doing search on my phone). I don't know that
they're actually introduced in the lesson anywhere, though.
So you're right that it would be good to explain them somewhere, and if not in a main lesson then at least in instructor notes. But I was actually following the model of earlier lessons in the PR.
On Mon, May 22, 2023, 4:40 AM Martino Sorbaro @.***> wrote:
Hi @ndporter https://github.com/ndporter, thank you for the PR. I note however that this requires explaining what \n means. Do you remember if there's another place before this point where it is used in the lesson materials?
Alternatively, what do you think of doing two prints? As in
print(filename) print(data.min())
— Reply to this email directly, view it on GitHub https://github.com/swcarpentry/python-novice-gapminder/pull/647#issuecomment-1556790888, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOKE445VBKDVHPDP3GF663XHMQ7ZANCNFSM6AAAAAAYIE4X3Y . You are receiving this because you were mentioned.Message ID: @.***>