git-novice icon indicating copy to clipboard operation
git-novice copied to clipboard

Make it clear that git status is introduced in Episode 3 (issue #685)

Open jdvorak001 opened this issue 5 years ago • 2 comments

I am suggesting this fix to issue #685.

jdvorak001 avatar Aug 14 '19 04:08 jdvorak001

Hey @jdvorak001 thanks for the review request! I'm sorry it's taken a bit to get to your PR. I'll do my best to get to it this week!

munkm avatar Jan 16 '20 19:01 munkm

Thanks for the review. It certainly is not the intent of this path to explain nested repositories, let alone promote them. It just warns against them (as does the currently released version). What I tried to plant is the good practice of running git status before git init. With that, the git status command is introduced a little.

jdvorak001 avatar Aug 02 '21 09:08 jdvorak001

I'm going to close this PR in preparation of the new workbench lesson architecture, but with the following points which halted the original merging of this PR.

PRs should be limited to one issue per PR. This PR attempted to do many things, and so the original issue - introducing git status at the very beginning - was lost and never implemented. I happen to tell learners that if they need to remember only one thing, it's git status. I absolutely agree with and approve moving it to prior to git init with explanation. However, there were questions about the other content that was added to the PR. Please submit issues as separate PRs in the future.

kekoziar avatar Apr 28 '23 21:04 kekoziar