git-novice icon indicating copy to clipboard operation
git-novice copied to clipboard

Lesson 08: A better description of the reviewing process through GitHub

Open RolandMacDoland opened this issue 6 years ago • 1 comments

Please delete the text below before submitting your contribution.


In lesson 08, when it comes to review the changes made by a Owner broached in the exercises, can be a bit more explanatory in my opinion. I could be mentioned that the Owner can add the Collaborator as a Reviewer and that he/she gets notified through the email address set at the beginning. This has the advantage to engage with the reviewing process on GitHub and what would make a good review, and how to resolve a conversation for a satisfactory merge of the PR.


RolandMacDoland avatar Dec 18 '18 15:12 RolandMacDoland

Hi @UCLGuichard. Thanks for the issue! Where exactly in lesson 08 do you think these changes should happen? Just after the a basic collaborative workflow callout box? One of the exercises in lesson 08 (Comment Changes in GitHub) talks a bit about interacting with Github and commenting on specific changes. What do you think about updating this exercise to be a bit clearer (some of the wording is unclear) and to also have one of the pair-programmers add their partner as a reviewer to solicit feedback on github?

munkm avatar Jan 22 '19 10:01 munkm