git-novice icon indicating copy to clipboard operation
git-novice copied to clipboard

Add missing periods in ep 05

Open tomeknd opened this issue 1 year ago • 5 comments

This is my first ever PR, so any feedback appreciated if applicable. Thank you for maintaining this awesome project!

tomeknd avatar Aug 25 '24 15:08 tomeknd

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • :dart: correct output
  • :framed_picture: correct figures
  • :question: new warnings
  • :bangbang: new errors

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1014

The following changes were observed in the rendered markdown documents:

 05-history.md | 2 +-
 md5sum.txt    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-08-26 09:49:45 +0000

github-actions[bot] avatar Aug 25 '24 15:08 github-actions[bot]

Thank you for catching the missing periods and for taking the time to submit this PR. I have to point out that the first change would render as git restore .. which looks an awful lot like git restore .. which is a different command (referring to the parent directory .. rather than the current directory .). So I would avoid the period there to avoid confusion...

martinosorb avatar Aug 25 '24 18:08 martinosorb

Makes sense, thank you for the feedback. If the other edit is to be applied, is there any further action needed on my part?

tomeknd avatar Aug 25 '24 18:08 tomeknd

I've updated it myself. I will not merge for a while because we are waiting for a larger merge which I don't want to conflict with this. Thank you.

martinosorb avatar Aug 26 '24 09:08 martinosorb

Thank you.

tomeknd avatar Aug 26 '24 14:08 tomeknd