swc icon indicating copy to clipboard operation
swc copied to clipboard

fix(es/compat): Insert loop Var into closest place

Open magic-akari opened this issue 7 months ago • 3 comments

Description:

BREAKING CHANGE:

Related issue (if exists):

  • Closes: #8300

magic-akari avatar Nov 19 '23 11:11 magic-akari

This doesn't seem to be the best solution. Consider following example

class Foo extends Bar {
    constructor() {
        for (const i of [1]) {
            setTimeout(() => {
                console.log(this)
            });
        }
        super();
    }
}

Austaras avatar Nov 19 '23 12:11 Austaras

This doesn't seem to be the best solution. Consider following example

class Foo extends Bar {
    constructor() {
        for (const i of [1]) {
            setTimeout(() => {
                console.log(this)
            });
        }
        super();
    }
}

@Austaras Test cases updated. IMO, it's OK

magic-akari avatar Nov 19 '23 13:11 magic-akari

It's not. The problem arises in access this before call super.

Austaras avatar Nov 19 '23 13:11 Austaras