wlroots
wlroots copied to clipboard
swaywm
button_count is corrupted when no pointer release is encountered
I am writing a program and I had it use right click as a means of exiting the event loop. I was trying to validate my serial to initiate a drag and drop and noticed that the serial in sway debug logs weren't being validated, but the button_count also seemed incorrect. It also kept incrementing.
I realized that by using right click to exit the program, button_count wasn't being decremented.
Tracking increments and decrements seems like it is a difficult balance act and could easily get corrupted if we encounter a state which is unaccounted for, so it seems like there needs to be an appropriate point at which we should reset button_count so as to at least have a catch-all in case we screw up.
In this case, if the surface originating a pointer event is destroyed, then it makes sense to reset the state.
wlroots has migrated to gitlab.freedesktop.org. This issue has been moved to:
https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/1716
