Finish tinywl.

[jsoo1]

Hello,

@LambdaCalrissian and me have been working on finishing the tinywl implementation. We have something close to a working version here with a few bugs to fix.

We completed the rest of the failwiths in the file and completed the ffi required to accomplish it.

There are certainly things here that might need discussion and, as mentioned it still has bugs.

Thanks for the great start!

[Armael]

Wow, thanks a lot for this work, that looks great! I appreciate it especially given that it's useful work that is also quite tedious to do by oneself :). I'll certainly need to refresh my memory a bit as it's been a while since I haven't touched this project, but I'll definitely try to have a look soon.

Did you hit any particular issues that you'd like to report, when building the project or extending the existing bindings?

[jsoo1]

Hey, thanks! It was a really great learning experience. I got from 0 to 1 with the ctypes library.

The only real problem came up about 2 weeks ago with the release of wlroots 0.13. A lot of the unstable features changed.

[Armael]

Yeah, I noticed today that the repo doesn't build anymore with the latest git version of wlroots. I'd like to try and look at whether wlroots could be vendored with the bindings, to make it easier to rely on a fixed version.

While I figure how to do that, could you tell me which git commit of wlroots you used when working on the bindings?

[jsoo1]

We were using the 0.12.0 tag.

I personally try to avoid vendoring whenever possible. I am not sure how fast 0.13 is going to be adopted in distros, though.

[Armael]

Thanks. I was thinking of vendoring only for developping the library, not for what would be a released version of the bindings. Because otherwise I have to uninstall/downgrade my system installation of wlroots (and thus sway) to work on the bindings, which is not very convenient.

[jsoo1]

Fair enough. I am using nix/guix to manage the wlroots installation so it's possible to have multiple versions installed. Totally understand if that does not help your process, though.

[Armael]

Ah, that's a very good point. Relying on nix or guix for development does sound simpler than figuring out vendoring. Would you mind sharing which setup you use for that? (if you have a nix/guix profile file it could be part of the repo) Does that mean that you don't use opam to setup your ocaml development environment?

[jsoo1]

I used opam pretty extensively but I don't think it would be entirely necessary. I could setup a nix shell or guix environment if you wish. Right now my setup is a bit of a patchwork.

[Armael]

Sorry for the delay, I just came back from holidays. I think if you could cook up a nix or guix environment that would be super useful (even more if it somehow works with opam, as that's what I know most). I tried to do that my self (with guix), but couldn't manage to make it work.

[Armael]

I've been suggested another approach on #sway-devel: to build wlroots and install it locally (e.g. in ~/.local), then tweak environment variables to point to the local installation. I guess that's a form of poor-man's nix environment, but if it works it would be convenient enough for me. I'll try that tonight and report back.

[jsoo1]

I can certainly setup a nix/guix environment. It might take a week or so, I'm quite busy right now

On Thu, Jul 8, 2021 at 3:58 AM Armaël Guéneau @.***> wrote:

I've been suggested another approach on #sway-devel: to build wlroots and install it locally (e.g. in ~/.local), then tweak environment variables to point to the local installation. I guess that's a form of poor-man's nix environment, but if it works it would be convenient enough for me. I'll try that tonight and report back.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/swaywm/wlroots-ocaml/pull/5*issuecomment-876341610__;Iw!!IKRxdwAv5BmarQ!M_CZEjO-9gbj1Pv9FiJ4jZ1mfNt4_EjVLU9Ot3BM65kXOSlUPe1ijsX7L3VNVQ$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACMTD2N7ASVUCJD4IUKLRXTTWWAEVANCNFSM46T7KZLQ__;!!IKRxdwAv5BmarQ!M_CZEjO-9gbj1Pv9FiJ4jZ1mfNt4_EjVLU9Ot3BM65kXOSlUPe1ijsV-QEgmMw$ .

[Armael]

Alright, don't worry too much then, it turns out the solution of installing wlroots in ~/.local works well for me; I could compile your branch and I'm currently doing the review :-).

[jsoo1]

Ok thanks! There are still a few bugs with it but thank you!

On Friday, Jul 09, 2021 at 1:23 PM, Armaël Guéneau @.*** @.***)> wrote:

Alright, don't worry too much then, it turns out the solution of installing wlroots in ~/.local works well for me; I could compile your branch and I'm currently doing the review :-).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://urldefense.com/v3/https://github.com/swaywm/wlroots-ocaml/pull/5*issuecomment-877436533;Iw!!IKRxdwAv5BmarQ!P2bGYfsMd8BqVtRDi7swmpCjCjJ2SqSGVs58PmwvndJGPy-ZaAtL-QFcMvX5yg$), or unsubscribe (https://urldefense.com/v3/https://github.com/notifications/unsubscribe-auth/ACMTD2KYOKA2F2X664WP56LTW5LDDANCNFSM46T7KZLQ;!!IKRxdwAv5BmarQ!P2bGYfsMd8BqVtRDi7swmpCjCjJ2SqSGVs58PmwvndJGPy-ZaAtL-QE2Pdo2nQ$).

[jsoo1]

Thanks for the detailed review! I'll be going over it this week.