wlr-protocols Allow xdg_toplevel surfaces as children of layers

Apr 27 '18 10:04 davidedmundson

Why?

Apr 27 '18 10:04 emersion

Scenario: we have a desktop background (and ours are interactive with keyboard focus and desktop icons) wtih a UI when clicked to configure that background which is a toplevel.

Apr 27 '18 11:04 davidedmundson

Can't that client just open a regular toplevel window?

Apr 27 '18 11:04 emersion

As a last resort, sure.

But semantically it's correct and we need to make sure we pass focus and to help hint which screen it should appear on.

Apr 27 '18 11:04 davidedmundson

This could be done with a set_parent_of request on the layer surface, similar to the one used in xdg-foreign.

Apr 27 '18 11:04 emersion

On Fri, Apr 27, 2018 at 04:03:11AM -0700, emersion wrote:

Can't that client just open a regular toplevel window?

That was my thought as well. Only thing I can think of is that you might not want to have it in the window list. Also layer-shell surfaces can have keyboard focus as well.

Apr 27 '18 11:04 agx

We should probably rename get_popup to adopt_popup and add adopt_toplevel.

Apr 27 '18 12:04 ddevault

We should probably rename get_popup to adopt_popup and add adopt_toplevel.

This is inconsistent with other protocols.

Apr 27 '18 12:04 emersion

set_parent_of isn't specific enough, and we can't do polymorphic requests.

Apr 27 '18 12:04 ddevault

Oh I guess if it takes an xdg_surface it'd be okay

Apr 27 '18 12:04 ddevault

wlr-protocols has migrated to gitlab.freedesktop.org. This issue has been moved to:

https://gitlab.freedesktop.org/wlroots/wlr-protocols/-/issues/12

Nov 01 '21 10:11 emersion