sway icon indicating copy to clipboard operation
sway copied to clipboard

contrib/inactive-windows-transparency fixes

Open gibbz00 opened this issue 3 years ago • 1 comments

Pull request an attempt to collect a multitude of unresolved and conflicting pull requests into logical commits for one hassle-free merge. Namely:

#6924 by aelfsyg

  • set active opacity with -a or --active-opacity

Test: ./contrib/inactive-windows-transparency.py -a 0.9

  • add a list of applications to ignore with --ignore

Test: ./contrib/inactive-windows-transparency.py --ignore firefox gimp

  • override active opacity for specific applications with -A or --active-overrides

Test: ./contrib/inactive-windows-transparency.py -A firefox=0.95 gimp=1

  • override inactive opacity for specific applications with -I or --inactive-overrides

Test: ./contrib/inactive-windows-transparency.py -I firefox=0.75 gimp=0.7

#6500 by tstivers1990.

  • show only one window as active when using multiple monitors

Test plan:

Preparation: More than one outputs (monitor) is required. Start script, create two windows on each output. Before: Move focus between outputs and observe that one window is active on each monitor. After: Move focus between outputs and observe that only one window is active.

#7104 by anpandey

  • properly reset opacity of hidden scratchpads upon exit

Test plan:

Preparation: Start script, create scratchpad, and make sure that it is hidden. Before: Stop script, open up scratchpad, and observe that it's opacity value remains. After: Stop script, open up scratchpad, and observe that its opacity value does not remain.


Further explanations about each commit are expressed in their own commit message. If there is anything I've missed, just let me know.

gibbz00 avatar Oct 03 '22 13:10 gibbz00

@emersion any plans to get this merged? I know it's low priority for you, but I put quite some time for it to be a clean one, don't think there is much work left to do.

gibbz00 avatar Nov 25 '22 10:11 gibbz00

Would be great to see this merged!

bakhtiyarneyman avatar Jan 28 '23 00:01 bakhtiyarneyman

Would be great to see this merged!

Unfortunately, I think you're better off copying the script yourself (and each time Sway is updated :/ ). One thing for devs to put this on their review backlog. But another to get completely ignored with no response whatsoever. Makes you really motivated to help fix open issues for a project that you love. /s

gibbz00 avatar Feb 09 '23 09:02 gibbz00

Sorry, but we don't have the bandwidth to review contrib/ material right now. We're having trouble even reviewing the bugfixes and minor core improvements. Please, understand that we are volunteers and that we cannot reply to everything.

Related: https://github.com/swaywm/sway/issues/7405

emersion avatar Feb 09 '23 10:02 emersion

The contrib/ directory has been moved from Sway to a separate repository: https://github.com/OctopusET/sway-contrib

Please re-open your pull request against the new repository.

emersion avatar Aug 02 '23 15:08 emersion