swarn

Results 26 comments of swarn

I'll repeat this here, because I think it's relevant, and I put too much noise in #445. I have my own `recursive_open` function that uses `fs.toggle_directory`. I find that it...

> I know some people will be apoplectic about colorschemes containing actual logic instead of being purely declarative... I think those concerns would be reasonable. If something like this is...

I thought about rule lifetimes, and in particular the interaction between colorscheme rules and buffer-scoped rules. Earlier, I thought that colorscheme authors could clear rules as with `:highlight clear`, but...

To be clear, are you recommending the following? 1. Remove `restore_default_rule` 2. Remove the `colorscheme` option in `add_rule` If so, I'll do both. For later, it might be easiest to...

> Followup bike to shed: do we really need to specify `.type.` and `.mod.`? I agree that it's unlikely there will be clashes between token types and modifiers. But, I...

I have no explanation for why `scripts/gen_vimdoc.py` does not see the new `clear_rules` function. It's probably an issue with my annotation formatting, but I cannot find it.

@clason, I have not ignored your earlier parenthetical note: > I also would prefer not to set implicit priorities based on order The implicit priority setting is not _required_ for...

Output of the modified `:Inspect` ![inspect](https://user-images.githubusercontent.com/926528/216497321-ceb419de-fe2b-44c5-bb72-a2fe47db2983.png)

> (sorry that it's going piecemeal, but this PR is a huge wall of text): I chose, for my _first_ neovim PR, a user-facing API for a new feature. That...

> * `filetype` can be easily looked up from `bufnr`, no need to pass it I agree. I used filetype lookup in the default rule and in the example above....