MultiCurrencyWallet icon indicating copy to clipboard operation
MultiCurrencyWallet copied to clipboard

Add Candle as a supported chain

Open samisbakedham opened this issue 2 years ago • 32 comments

Checklist

  • [x] I have read the CONTRIBUTING guide
  • [x] Good naming (as clear and simple as possible)
  • [x] Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • [x] I tested desktop/mobile resolution
  • [x] I tested light/dark theme
  • [x] I tested different languages
  • [x] I checked the functionality once again (AFFECT MONEY)
  • [x] I checked the work on the Testnet
  • [x] I checked the work on the Mainnet
  • [x] I checked the work in the plugin
  • [x] I checked the PR once again

samisbakedham avatar Jun 23 '22 01:06 samisbakedham

@samisbakedham did you test it?

J94k avatar Jun 23 '22 12:06 J94k

@samisbakedham did you test it?

Yes

samisbakedham avatar Jun 23 '22 15:06 samisbakedham

@samisbakedham did you test it?

Yes

I launched this branch and don't see the coin or tokens for this network

J94k avatar Jun 24 '22 02:06 J94k

@samisbakedham did you test it?

Yes

I launched this branch and don't see the coin or tokens for this network

I'll check and fix!

samisbakedham avatar Jun 24 '22 03:06 samisbakedham

@samisbakedham please don't mark checkboxes if you don't complete them

J94k avatar Jun 24 '22 04:06 J94k

@samisbakedham please don't mark checkboxes if you don't complete them

Fixed, and will push soon'

samisbakedham avatar Jun 24 '22 04:06 samisbakedham

@NotEternal How does it look now on your end? The tests I ran checked out

samisbakedham avatar Jun 26 '22 17:06 samisbakedham

@samisbakedham you don't have candle_ApiKey anywhere. If you don't have network API, just leave an empty string for cndlscan and candle_ApiKey. If you have API, then use these keys everywhere: cndl_ApiKey, cndlscan

J94k avatar Jun 27 '22 08:06 J94k

@samisbakedham for the testing I need:

  • CNDL amount (for example 1)
  • some token amount (any 10 tokens)
  • two tokens from existing pool in dex.CNDLchain.com (also 10 each of them)

Send it to this address: 0x4086a2CAe8d3FcCd94D1172006516C7d0794C7Ee

J94k avatar Jun 27 '22 08:06 J94k

@samisbakedham for the testing I need:

  • CNDL amount (for example 1)

  • some token amount (any 10 tokens)

  • two tokens from existing pool in dex.CNDLchain.com (also 10 each of them)

Send it to this address: 0x4086a2CAe8d3FcCd94D1172006516C7d0794C7Ee

I'll work on fixing the highlighted code you reviewed, thank you and just sent the tokens for testing now.

samisbakedham avatar Jun 27 '22 08:06 samisbakedham

add CNDL here: file

J94k avatar Jun 27 '22 08:06 J94k

Wrong link source:

image

J94k avatar Jun 27 '22 08:06 J94k

Wrong link source:

image

Wrong link source?

samisbakedham avatar Jun 28 '22 01:06 samisbakedham

add CNDL here: file

Done

samisbakedham avatar Jun 28 '22 01:06 samisbakedham

  • I cannot see CNDL coin in the internal wallet after selecting it here: image

  • Maybe the same reason for this bug, I cannot see and update my CNDL balance in Quickswap: image

  • Cannot see CNDL in a Deposit window and smth weard with background: image image

  • Problem in direct swap. Trying to swap CNDL with DAI. The second input is empty and we can see this error: amountOut Error: Returned error: execution was reverted

J94k avatar Jun 29 '22 06:06 J94k

I disable CNDL in the testnet config, but still see a tokens option in the "Create a wallet" screen: image

J94k avatar Jun 29 '22 07:06 J94k

  • I cannot see CNDL coin in the internal wallet after selecting it here: image
  • Maybe the same reason for this bug, I cannot see and update my CNDL balance in Quickswap: image
  • Cannot see CNDL in a Deposit window and smth weard with background: image image
  • Problem in direct swap. Trying to swap CNDL with DAI. The second input is empty and we can see this error: amountOut Error: Returned error: execution was reverted

It works now I think

samisbakedham avatar Jun 29 '22 07:06 samisbakedham

@samisbakedham you cannot lounch and test it? Please do it yourself first.

J94k avatar Jun 29 '22 07:06 J94k

@samisbakedham you cannot lounch and test it? Please do it yourself first.

I tested it and it works for me

samisbakedham avatar Jun 29 '22 07:06 samisbakedham

strange, then send a short video with CNDL wallet addition

J94k avatar Jun 29 '22 07:06 J94k

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

samisbakedham avatar Jun 29 '22 07:06 samisbakedham

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

Just send it here. It has to be not longer then several seconds. The moment when you add CNDL in the wallet.

J94k avatar Jun 29 '22 08:06 J94k

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

Just send it here. It has to be not longer then several seconds. The moment when you add CNDL in the wallet.

image

samisbakedham avatar Jun 29 '22 21:06 samisbakedham

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

Just send it here. It has to be not longer then several seconds. The moment when you add CNDL in the wallet.

2022-06-29 (2)

samisbakedham avatar Jun 30 '22 01:06 samisbakedham

On your screen is an external wallet (Metamask in this case). With external wallets we don't have problems. I'm talking about internal wallet, when you just started and create it from the "Create a wallet" screen.

J94k avatar Jun 30 '22 02:06 J94k

On your screen is an external wallet (Metamask in this case). With external wallets we don't have problems. I'm talking about internal wallet, when you just started and create it from the "Create a wallet" screen.

Ah. I'll check now

samisbakedham avatar Jun 30 '22 03:06 samisbakedham

On your screen is an external wallet (Metamask in this case). With external wallets we don't have problems. I'm talking about internal wallet, when you just started and create it from the "Create a wallet" screen.

image

samisbakedham avatar Jun 30 '22 03:06 samisbakedham

@samisbakedham do you use this app? If so maybe it's easier to use your fork instead. You already fork it.

J94k avatar Jun 30 '22 12:06 J94k

@samisbakedham do you use this app? If so maybe it's easier to use your fork instead. You already fork it.

I'm trying to add support for it in the main repo for others too

samisbakedham avatar Jun 30 '22 20:06 samisbakedham

@samisbakedham I was talking with a team and your network does not match for integration possibility. You can check requirements here: https://support.onout.org/hc/1331700057/32/addnewnetwork?category_id=8

J94k avatar Jul 01 '22 05:07 J94k