swag-for-dev
swag-for-dev copied to clipboard
feat: Add Last updated on to each item in the list
- [x] I've checked that this isn't a duplicate pull request.
Added 'Last updated on' for each item in the list based on the dateAdded from data.json as per the issue #266

Thoughts on this?
(for reference, this is what it currently looks like:)

@vikaspotluri123 I like it. I'll realign it to one single line and since Check it out won't change, it shouldn't affect the layout and will still look similar to what we have right now.
Should we close this PR until I submit a fresh PR with the new layout you suggested?
You can just add commits to this PR 😄
@vikaspotluri123 getting there with this git game. Thanks.
Pushed the changes.
@vikaspotluri123 Can we merge this?
@harishkotra Can you remove changes from data.json?
@harishkotra Can you remove changes from data.json?
Done.
Please rebase so we can run UI sanity checks as well 💃
Please rebase so we can run UI sanity checks as well 💃
@vikaspotluri123 done :)
Doesn't seem to have worked... did you force push?
Doesn't seem to have worked... did you force push?
Nope. There is an image URL in data.json that stopped working. I just did a rebase, updated the style as per @aslafy-z 's comment and pushed it. Didn't do any force push.
I just did a rebase
If you did a rebase, you won't be able to update your branch here unless you force push
date added != last updated. @vikaspotluri123 we need to work on this
For now we can change it to added... When we add the updated "column" to the "database", we can update this as well. I want to wait for hacktoberfest to be over before making changes like this so we can limit the number of PRs that have to be rebased