swag-for-dev icon indicating copy to clipboard operation
swag-for-dev copied to clipboard

feat: Add Last updated on to each item in the list

Open harishkotra opened this issue 6 years ago • 14 comments

  • [x] I've checked that this isn't a duplicate pull request.

Added 'Last updated on' for each item in the list based on the dateAdded from data.json as per the issue #266

harishkotra avatar Oct 01 '19 02:10 harishkotra

Suggested UI

Thoughts on this?

(for reference, this is what it currently looks like:) image

vikaspotluri123 avatar Oct 01 '19 13:10 vikaspotluri123

@vikaspotluri123 I like it. I'll realign it to one single line and since Check it out won't change, it shouldn't affect the layout and will still look similar to what we have right now.

Should we close this PR until I submit a fresh PR with the new layout you suggested?

harishkotra avatar Oct 01 '19 16:10 harishkotra

You can just add commits to this PR 😄

vikaspotluri123 avatar Oct 01 '19 16:10 vikaspotluri123

@vikaspotluri123 getting there with this git game. Thanks.

Pushed the changes.

harishkotra avatar Oct 01 '19 16:10 harishkotra

@vikaspotluri123 Can we merge this?

harishkotra avatar Oct 05 '19 08:10 harishkotra

@harishkotra Can you remove changes from data.json?

swapagarwal avatar Oct 05 '19 09:10 swapagarwal

@harishkotra Can you remove changes from data.json?

Done.

harishkotra avatar Oct 05 '19 10:10 harishkotra

Please rebase so we can run UI sanity checks as well 💃

vikaspotluri123 avatar Oct 05 '19 16:10 vikaspotluri123

Please rebase so we can run UI sanity checks as well 💃

@vikaspotluri123 done :)

harishkotra avatar Oct 05 '19 17:10 harishkotra

Doesn't seem to have worked... did you force push?

vikaspotluri123 avatar Oct 05 '19 17:10 vikaspotluri123

Doesn't seem to have worked... did you force push?

Nope. There is an image URL in data.json that stopped working. I just did a rebase, updated the style as per @aslafy-z 's comment and pushed it. Didn't do any force push.

harishkotra avatar Oct 05 '19 18:10 harishkotra

I just did a rebase

If you did a rebase, you won't be able to update your branch here unless you force push

vikaspotluri123 avatar Oct 05 '19 18:10 vikaspotluri123

date added != last updated. @vikaspotluri123 we need to work on this

aslafy-z avatar Oct 16 '19 00:10 aslafy-z

For now we can change it to added... When we add the updated "column" to the "database", we can update this as well. I want to wait for hacktoberfest to be over before making changes like this so we can limit the number of PRs that have to be rebased

vikaspotluri123 avatar Oct 16 '19 00:10 vikaspotluri123