JARVIS-on-Messenger icon indicating copy to clipboard operation
JARVIS-on-Messenger copied to clipboard

Explore pre-commit hooks

Open swapagarwal opened this issue 6 years ago • 17 comments

Explore if we can have a pre-commit hook to check the sorted order of modules in init.py

swapagarwal avatar Mar 27 '18 18:03 swapagarwal

Hi! I have never contributed to an open-source project before, but need to for a school project. Do you think this would be a reasonable bug for me to handle? I have used Python before.

Thanks

Aliya

aliyareneekhan avatar Apr 02 '18 03:04 aliyareneekhan

Yep! Go ahead. Let me know if you face any issues. 😄

swapagarwal avatar Apr 02 '18 17:04 swapagarwal

@aliyareneekhan are you still working on this?

palaparthi avatar Apr 18 '18 05:04 palaparthi

Hi! I am new to open-source. Can you please give me pointers on how this needs to be done?

Thank you, Suhas

suhasjrv avatar Apr 20 '18 06:04 suhasjrv

@suhasjrv Take a look at https://githooks.com/

swapagarwal avatar Apr 21 '18 04:04 swapagarwal

@swapagarwal I've created a pre-commit hook for this. Should I add a directory for hooks so client can manually link to the hook?

einsmein avatar Apr 24 '18 16:04 einsmein

Yes. Try adding it at .git/hooks/pre-commit

swapagarwal avatar Apr 24 '18 17:04 swapagarwal

@swapagarwal I have already added it there, but .git is not pushed to remote. I'm wondering how you would like it to be added to this repo. Maybe something like this? https://stackoverflow.com/a/3464399/3053806

einsmein avatar Apr 25 '18 01:04 einsmein

Hi. May I know if the issue is still open? The tag indicates that it is so but I saw that a pull request has already been accepted. Thanks.

rajalakshmi-v15 avatar Jun 21 '18 10:06 rajalakshmi-v15

Hello, I am a new user to github. Can anyone tell me what exactly one can do to contribute to open source and how to solve an issue ?

pawanr90 avatar Aug 19 '18 17:08 pawanr90

Is the issue still open?

ritesh-pandey avatar Sep 25 '19 16:09 ritesh-pandey

Hey if this issue is still open I'm happy to take a crack at it.

CarlaLeal avatar Nov 10 '19 16:11 CarlaLeal

Checking the issue is still open, would love to contribute.

ghost avatar Jan 05 '20 17:01 ghost

Checking the issue is still open, would love to contribute.

+1

mattany avatar Apr 07 '20 21:04 mattany

Is this issue open then I would like to contribute

Sanchayan-Bhowal avatar Oct 08 '20 14:10 Sanchayan-Bhowal

Is the issue still open?

Kaweees avatar Jan 04 '21 22:01 Kaweees

Is this issue still open, if yes i would like to work on it

tuhinmallick avatar Jan 06 '23 05:01 tuhinmallick