Jesse Wilson

ConsoleTest is flaky

1

Sometimes it fails like this: ``` app.cash.zipline.ConsoleTest[jvm] > logWithArguments[jvm] FAILED java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) ```

Key-value metadata in Manifest

1

We currently have one user-owned metadata field in ZiplineManifest: ``` /** Version to represent the code as defined in this manifest, by default it will be Git commit SHA. */...

For example, this: ```kotlin interface ListService : ZiplineService { fun createList(): List } ``` Will crash like this: ``` java.lang.ClassCastException: class org.jetbrains.kotlin.ir.types.impl.IrStarProjectionImpl cannot be cast to class org.jetbrains.kotlin.ir.types.IrType (org.jetbrains.kotlin.ir.types.impl.IrStarProjectionImpl and...

Try to turn off / avoid using `eval()` as much as possible

9

It’s a potential sandbox-escape if we end up running unexpected code.

Signatures defend against untrusted code attacks. We could further increase our security by defending against code-rollback attacks. In that attack, the app is tricked into loading an old version that...

Some simple-seeming programs need -Xss2048k

1

We overflowed the macOS x86_64 default stack size with a small number of mutually-calling `suspend` functions, as described in [PR 844](https://github.com/cashapp/zipline/pull/844). This wasn’t a program that did a significant amount...

I’ve got an implementation of `EventListener.callStart()` that is throwing an exception. This is bad! `EventListeners` mustn’t throw exceptions. But still, the failure mode is very awful: ``` app.cash.zipline.ZiplineException: InternalError: Java...

ZiplineService interface must be declared directly

1

This doesn’t work as it aught to: ``` interface A : ZiplineService { fun a() } interface B : A { fun b() } ``` In particular we don’t generate...

This test passes on JDK 11. On JDK 17: ``` FAIL testcase 144 (Signature with special case values for r and s): accepting invalid signature FAIL testcase 147 (Signature with...