Swanand Mulay

Results 117 comments of Swanand Mulay

note that it won't _fix_ #595 as broker still doesn't perform the checks, and doing that in separate PR is preferable. I would recommend to remove that from PR description...

@henil is the bug fix still required? most of the changes already existed in main branch, I resolved the merge conflicts, can you have a look at current state of...

Hey, is there any significant advantage of having them on same port? Currently, as `Network` has the `P: Protocol`, it knows how to read the packets ( including connect ),...

> As for reading the packets. Since both 3.1.1 and 5 have similar header and start of connect I tried to have P: Protocol be changed after reading Agreed. I...

hey @flxo , any idea why this might be happening?

hey, thanks for reporting. in case 3, you can increase the timeout duration, e.g. `connection.recv_timeout(Duration::from_secs(1))`, it will work. for case 2, i will get back to you!

hey @ecarrara , thank you so much for the PR! ( I didn't expect PR this fast haha :rocket: ) > It looks like a big breaking change Yes, I...

Hey @drauschenbach , good catch! would you like to open PR to solve the issue? ( just need to add `pub use Strategy` in router/mod.rs ig ) Otherwise, I will...

Hey, rumqttc doesn't support it right now, but would be nice to have! also there is #609 , I'm thinking we can modify `ack` fn to take `Ack` as suggested...

is this issue resolved @SirVer @ctron ? if yes, can we close it?