swag icon indicating copy to clipboard operation
swag copied to clipboard

Published 20 hours ago • verified publisher icon swaggo

✍🏻 UPDATE(writeonly): add support for writeonly for schema prop types

Open tekpriest opened this issue 3 years ago • 5 comments

Describe the PR Support for writeonly tag concerning this issue https://github.com/swaggo/swag/issues/1139

Additional context I submitted an issue for writeonly tag support for swaggo. Here is my proposed solution to it. Hopefully I didn't make too much blunder as this is my first time contributing to Open Source. Here is the link to the issue https://github.com/swaggo/swag/issues/1139.

tekpriest avatar Feb 24 '22 14:02 tekpriest

@en1tan Unit tests are failing. I will start doing a Code Review only when all unit tests pass.

ubogdan avatar Mar 08 '22 11:03 ubogdan

alright

tekpriest avatar Mar 09 '22 16:03 tekpriest

Please fix the conflict in field_parser.go, and I will do my best to review it.

ubogdan avatar Jun 18 '22 13:06 ubogdan

sure, will do that

tekpriest avatar Jun 18 '22 14:06 tekpriest

@ubogdan fixed

tekpriest avatar Jun 23 '22 12:06 tekpriest

@en1tan your PR doesn't pass unit tests.

ubogdan avatar Aug 19 '22 20:08 ubogdan

@en1tan your PR doesn't pass unit tests.

It's been sometime I checked the fork, will update and let you know

tekpriest avatar Aug 20 '22 12:08 tekpriest

@ubogdan I see the issue is with my request. go-openapi does not have support for writeOnly neither does openapi 2.0

tekpriest avatar Aug 21 '22 19:08 tekpriest

writeOnly is an OAS3-specific feature https://swagger.io/specification/#schema-object. Swag is currently supporting OAS 2.0

ubogdan avatar Aug 22 '22 12:08 ubogdan

yeah, I will close this PR now

tekpriest avatar Aug 28 '22 11:08 tekpriest