json-diff icon indicating copy to clipboard operation
json-diff copied to clipboard

Add PHP 8.4 support

Open cedric-anne opened this issue 1 year ago • 2 comments

Implicitly nullable parameter declarations are deprecated in PHP 8.4. The proposed change is safe and is not considered by PHP as a signature change, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Unfortunately, this syntax is compatible only with PHP >= 7.1. I propose to raise the minimal PHP requirement to 7.1.

cedric-anne avatar Jul 29 '24 07:07 cedric-anne

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.99%. Comparing base (17bfc66) to head (ece85d8). Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   96.96%   96.99%   +0.03%     
==========================================
  Files          15       15              
  Lines         593      599       +6     
==========================================
+ Hits          575      581       +6     
  Misses         18       18              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 29 '24 07:07 codecov[bot]

Ping @vearutop .

The deprecation warning on PHP 8.4 is preventing us to active our CI checks on this incoming PHP version. We could still apply manually a patch, but we would prefer to help to fix it in your lib directly.

cedric-anne avatar Sep 04 '24 10:09 cedric-anne

Can we have another look at this now that https://github.com/swaggest/json-diff/releases/tag/v3.12.0 is out?

reedy avatar Mar 07 '25 22:03 reedy