swagger-ui icon indicating copy to clipboard operation
swagger-ui copied to clipboard

Swagger UI Could not resolve reference: Could not resolve pointer: After upgrading to SwashBuckle 6.3.0 with latest Swagger UI

Open PTAdvanced opened this issue 2 years ago • 9 comments

I am experiencing an issue with the Swagger UI after upgrading from Swashbuckle 6.2.3 to 6.3.0.

After some investigation, the issue appears to be with Swagger UI and not the swagger.json document generated by Swashbuckle, hence my posting here.

When navigating to the Swagger UI, and expanding one of my methods, the "Example Value | Schema" section simply displays

"string"

At the top of the Swagger UI a message appears:

Resolver error at paths./request/requestsingledevicefromsite.post.requestBody.content.application/json.schema.$ref Could not resolve reference: Could not resolve pointer: /components/schemas/Advanced.Cloud.Live.DomainModel.FireSystemDigitalTwin.Sychronisation.OutboundRequest.CQRS.RequestStatusOfSingleDeviceAtSite+Command does not exist in document

I browsed the generated swagger.json document, and looked for the "Advanced.Cloud.Live.DomainModel.FireSystemDigitalTwin.Sychronisation.OutboundRequest.CQRS.RequestStatusOfSingleDeviceAtSite+Command" reference.

I find it within the "paths" object, and see that the "$ref" property is pointing to the "Advanced.Cloud.Live.DomainModel.FireSystemDigitalTwin.Sychronisation.OutboundRequest.CQRS.RequestStatusOfSingleDeviceAtSite+Command" object.

"/request/requestsingledevicefromsite": {
  "post": {
	"tags": [
	  "FireSystemRequest"
	],
	"operationId": "RequestSingleDeviceFromSite",
	"requestBody": {
	  "content": {
		"application/json": {
		  "schema": {
			"$ref": "#/components/schemas/Advanced.Cloud.Live.DomainModel.FireSystemDigitalTwin.Sychronisation.OutboundRequest.CQRS.RequestStatusOfSingleDeviceAtSite+Command"
		  }
		}
	  }
	},
	"responses": {
	  "201": {
		"description": "Created"
	  },
	  "401": {
		"description": "Unauthorized",
		"content": {
		  "application/json": {
			"schema": {
			  "$ref": "#/components/schemas/Microsoft.AspNetCore.Mvc.ProblemDetails"
			}
		  }
		}
	  },
	  "400": {
		"description": "Bad Request",
		"content": {
		  "application/json": {
			"schema": {
			  "$ref": "#/components/schemas/Microsoft.AspNetCore.Mvc.ProblemDetails"
			}
		  }
		}
	  },
	  "403": {
		"description": "Forbidden"
	  }
	}
  }
},

Further down the swagger.json document, the reference is located, within the "components" / "schemas" section:

"Advanced.Cloud.Live.DomainModel.FireSystemDigitalTwin.Sychronisation.OutboundRequest.CQRS.RequestStatusOfSingleDeviceAtSite+Command": {
        "type": "object",
        "properties": {
          "SiteId": {
            "type": "string",
            "format": "uuid"
          },
          "NodeId": {
            "type": "integer",
            "format": "int32"
          },
          "Loop": {
            "type": "integer",
            "format": "int32"
          },
          "Address": {
            "type": "integer",
            "format": "int32"
          },
          "SubAddress": {
            "type": "integer",
            "format": "int32"
          }
        },
        "additionalProperties": false
      },

I downloaded the swagger.json generated by both the v6.2.3 and v6.3.0 Swashbuckle, performing a text diff on the 2 files. They are almost identical, apart from the HTTP 201 responses having a description of "Success" in the v6.2.3 document and "Created" in the v6.3.0 document.

I believe Swashbuckle recently upgraded from Swagger UI 4.1.3 to 4.5.0

PTAdvanced avatar Mar 15 '22 17:03 PTAdvanced

The issue seems to be due to the + in the Schema ref name.

I had configured the SwaggerGen as follows:

services.AddSwaggerGen(c =>
{
    c.CustomSchemaIds(s => s.FullName);
    ...
}

But modifying as:

services.AddSwaggerGen(c =>
{
    c.CustomSchemaIds(s => s.FullName.Replace("+", "."));
}

generates a schema $ref without the +

Swagger UI did not seem to have an issue with the + in the $ref name previously.

PTAdvanced avatar Mar 15 '22 22:03 PTAdvanced

Thanks for this, found the same issue in our fairly complex production API and this fixed it. Bizarrely, when I created a new bare bones webapi project, then added an endpoint that uses a nested ".Command" class for the request body, the Swagger page works fine using Swashbuckle 6.3.1, despite the underlying JSON schema specifying the "ParentClass+Command" format. Very odd.

steveblomeley avatar Jul 09 '22 11:07 steveblomeley

Why isn't this fixed?!

ClassyCircuit avatar Jul 27 '22 07:07 ClassyCircuit

Have the same issue with Swashbuckle.AspNetCore 6.4.0

huesla avatar Dec 07 '22 13:12 huesla

Same with 6.5.0

CodyBatt avatar Jan 13 '23 17:01 CodyBatt

Fixed with

builder.Services.AddSwaggerGen(options => { options.CustomSchemaIds(type => type.ToString()); });

enzoeuler avatar Jan 26 '23 18:01 enzoeuler

The issue seems to be due to the + in the Schema ref name.

I had configured the SwaggerGen as follows:

services.AddSwaggerGen(c =>
{
    c.CustomSchemaIds(s => s.FullName);
    ...
}

But modifying as:

services.AddSwaggerGen(c =>
{
    c.CustomSchemaIds(s => s.FullName.Replace("+", "."));
}

generates a schema $ref without the +

Swagger UI did not seem to have an issue with the + in the $ref name previously.

We are using Swashbuckle.AspNetCore 6.5.0 on a .NET 7 project and I had to use this solution to avoid errors with Nested types. Is there a better fixe since this message that is one year old? thx.

Uleertel avatar Feb 27 '23 10:02 Uleertel

Unfortunately, the new version has an issue with the + Thanks for your investigation.

EhsanRezaei1981 avatar Jul 18 '23 12:07 EhsanRezaei1981