swagger-ui
swagger-ui copied to clipboard
fix: Consistent usage of ≤ and ≥ when displaying min/max attributes
Description
See the screenshots below. When displaying min/max attributes of schema properties, the schema renderer used a mix of ≤ ≥ and >= <= characters. This inconsistency was bugging me, so I changed all uses to ≤ ≥. (If you prefer >= <=, let me know and I'll update the PR.)
OpenAPI spec for testing: https://gist.githubusercontent.com/hkosova/dc9ea2c285b61cd36a5ec8eb18b43676/raw/7defc7378734e7494d7ec3a2bf0928bc7fe9ff48/min-max.yaml
Motivation and Context
Consistency.
How Has This Been Tested?
Tested manually by comparing visual appearance before and after the change.
Screenshots (if appropriate):
Before:
After:
Checklist
My PR contains...
- [ ] No code changes (
src/is unmodified: changes to documentation, CI, metadata, etc.) - [ ] Dependency changes (any modification to dependencies in
package.json) - [x] Bug fixes (non-breaking change which fixes an issue)
- [ ] Improvements (misc. changes to existing features)
- [ ] Features (non-breaking change which adds functionality)
My changes...
- [ ] are breaking changes to a public API (config options, System API, major UI change, etc).
- [ ] are breaking changes to a private API (Redux, component props, utility functions, etc.).
- [ ] are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
- [x] are not breaking changes.
Documentation
- [x] My changes do not require a change to the project documentation.
- [ ] My changes require a change to the project documentation.
- [ ] If yes to above: I have updated the documentation accordingly.
Automated tests
- [ ] My changes can not or do not need to be tested.
- [ ] My changes can and should be tested by unit and/or integration tests.
- [ ] If yes to above: I have added tests to cover my changes.
- [ ] If yes to above: I have taken care to cover edge cases in my tests.
- [x] All new and existing tests passed.