swagger-play icon indicating copy to clipboard operation
swagger-play copied to clipboard

Handle route delegation properly

Open larochef opened this issue 8 years ago • 6 comments

When a set of routes is delegated to another router, there is a missing "/" between the prefix of the delegated route and the last part of the route.

For instance:

->       /endpoint        myEndpoint.router.Routes

and in the myEndpoint.router.routes:

GET    /my/endpoint     ....

would end up with url /endpointmy/endpoint insead of /endpoint/my/endpoint

larochef avatar Feb 10 '17 08:02 larochef

@larochef could you add some test cases?

pjfanning avatar Feb 11 '17 19:02 pjfanning

@pjfanning i'll have a look at how the delegation can be done in tests

larochef avatar Feb 13 '17 08:02 larochef

@pjfanning I've added some tests, they helped me see some forgotten cases.

larochef avatar Feb 14 '17 22:02 larochef

@pjfanning did you get a chance to have a look at it ?

larochef avatar Feb 22 '17 13:02 larochef

@larochef your change looks ok to me but you'll need a Member to review and merge

pjfanning avatar Feb 22 '17 14:02 pjfanning

I have the same problem and would like this fix. Is it going to be merged soon and released to maven ?

JFCote avatar Mar 08 '17 19:03 JFCote