swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

Implemented thread safe storage of SessionManager for Alamofire

Open JohannesNevels opened this issue 7 years ago • 0 comments

PR checklist

  • [ ] Read the contribution guidelines.
  • [ ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ ] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @ehyche

Description of the PR

Fixed random cancelling Alamofire requests due to saving the references in a not thread safe dictionary. This occurs when doing multiple request at the same time. One or multiple requests are deallocated / cancelled when references are not correctly stored.

JohannesNevels avatar Jul 05 '18 12:07 JohannesNevels